jumpinjackie / mapguide-react-layout / 26217711843

61%

Build Type

push

github

Committed by web-flow

Commit Message

Implement spy mode (#1651)

* Enhance context documentation for map comparison and introduce generalization of comparison modes

* Generalize swipe state to comparisons

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add spy comparison mode

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix minimal popover stacking

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix generic layout popover not appearing on button click

Two bugs prevented popover toolbar buttons from showing in the generic
viewer layout template:

1. Z-index timing gap: react-tiny-popover applies containerStyle via
   useEffect (after browser paint), so the portal container was briefly
   at z-index:auto before the first paint. For positioned elements in the
   same stacking context, z-index:auto stacks below elements with explicit
   positive z-index (e.g. the toolbar group at z-index:10). Switched from
   containerStyle to containerClassName + a CSS rule, which applies z-index
   synchronously at element-creation time via useState initialiser in
   react-tiny-popover's useElementRef.

2. focus() stealing in onMouseDown: spy mode added tabIndex+focus() to
   map-viewer-component so keyboard ArrowUp/Down resize the spy cursor.
   That focus() was called for every mousedown inside the component,
   including clicks on toolbar popover-trigger buttons, stealing focus
   before the click event completed and potentially disrupting the
   click-outside detection cycle. Fixed by only calling focus() when the
   mousedown target is not a button/input/interactive element.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix popover positioning in generic template by giving html/body proper height

react-tiny-popover uses document.body as the default boundary element when
positioning popovers. In generic.html, html and body had no explicit height,
so getBoundingClientRect() returned height=0 / bot... (continued)

Coverage Stats

3289 of 4035 branches covered (81.51%)

178 of 582 new or added lines in 16 files covered. (30.58%)

7 existing lines in 4 files now uncovered.

16218 of 26789 relevant lines covered (60.54%)

14.3 hits per line