prisma-risk / tsoracle / 26211786498

95%

push

github

feat: add failpoint testing for driver-file and server paths (#22)

* feat: add failpoint testing for driver-file and server paths

Introduce fault-injection testing via the `fail` crate, with eight failpoint
sites across `tsoracle-driver-file` (write_record crash boundaries) and
`tsoracle-server` (leader-watch fence + service path). Each opting-in crate
gets a per-crate `failpoints` Cargo feature (off by default) and a tiny
`failpoint!` wrapper macro that expands to nothing without the feature, so
release builds physically cannot contain failpoint code.

Sites and the invariants they exercise:

- `file_driver::before_write`, `::after_tmp_fsync_before_rename`,
  `::after_rename_before_dir_fsync`: assert that a crash at each persist-
  pipeline boundary leaves the canonical state file consistent on reopen.
- `file_driver::write_blocked`: generalizes the prior ad-hoc `SLOW_WRITE_HOOK`
  + `PERSIST_TEST_SERIAL` machinery, which is removed. The rewritten
  `load_is_not_blocked_by_in_flight_persist` test uses `fail::cfg_callback`
  for a deterministic entry handshake.
- `server::fence::after_load_before_persist`, `::after_persist_before_publish`:
  assert that a fault in the leader-watch task does not advance serving state,
  and observably preserves the durable-vs-serving split.
- `server::service::before_allocate`, `::extension_gate_held`: wiring tests
  for the request and extension-gate paths.

The closure form of the wrapper produces the enclosing function's exact
return type (`Result<(), FileDriverError>`, `Result<(), ServerError>`, etc.)
so failpoint returns are type-safe.

`openraft-toolkit` gains the feature/wrapper wiring but no sites yet; the
log-store failpoints were deferred to a follow-up because the openraft 0.10
`RaftLogStorage::append` test scaffolding warrants its own design pass.

`make test-failpoints` runs the suite. The existing CI `test` job already
runs `cargo test --workspace --all-features`, which activates the failpoint
features ... (continued)

38 of 38 new or added lines in 4 files covered. (100.0%)

2425 of 2594 relevant lines covered (93.48%)

205152.95 hits per line