wboayue / rust-ibapi / 26198842711

92%

push

github

orders: type Execution.side as ExecutionSide (typed-status sweep PR 5b) (#606)

C# Execution.cs:83 is authoritative: documented wire vocabulary is two
values, BOT and SLD. Short-sale fills emit SLD — the SSHORT designation
lives on the originating Action, not on Execution.side. The original
"wait for stock-RTH short-sale capture" gate was over-conservative;
PR 5a Phase-1 capture ({BOT, SLD}) matched the spec.

Exhaustive enum (no #[non_exhaustive]) since the field is binary in
the IBKR spec — callers get a compile-time signal if a hypothetical
third variant is ever added. Strict FromStr rejects unknown wire
strings via Error::Parse before any match fires.

- decode_execution returns Result<Execution, Error>; caller in
  decode_execution_data_proto uses transpose()? matching the contract
  decoder precedent.
- Default on ExecutionSide is Bought (arbitrary, only observed on
  placeholder Execution::default() instances).
- Test fixtures keep wire-format String (proto field).
- Added round-trip + reject-unknown tests; strengthened existing
  decoder tests with side assertion.
- Migration §23; tracker marked shipped.

19 of 19 new or added lines in 3 files covered. (100.0%)

19010 of 20630 relevant lines covered (92.15%)

27.34 hits per line