stacklok / toolhive / 26171086378

66%

Build Type

push

github

Committed by web-flow

Commit Message

Factor thv-operator main into app.Run; add proxyrunner Run helper (#5332)

* Factor operator main into app.Run, add proxyrunner Run helper

Implements changes for issue #5326:
- Move all pre-Run setup from cmd/thv-operator/main.go (scheme registration,
  flag parsing, logger init, signal context, manager construction) into a
  new cmd/thv-operator/app package exposing a single Run() entry point.
- Add additive Run() helper to cmd/thv-proxyrunner/app that absorbs the
  viper env binding, logger init, signal-aware context, and root command
  execution from cmd/thv-proxyrunner/main.go.
- Shrink both main.go files to two-line wrappers that call app.Run(),
  enabling out-of-tree builds to wrap the binaries via a literal
  func main() { app.Run() }.

This is a mechanical code move with no behavior change. All existing
flags, environment variables, exit codes, and signal handling are
preserved unchanged.

* Apply review polish to operator/proxyrunner refactor

Addresses stacklok/toolhive#5332 review comments:
- MEDIUM cmd/thv-operator/app/app.go (3267942319): shorten Run() doc;
  "never returns" was inaccurate (mgr.Start returns nil on clean signal
  shutdown) and exceeded the project "one short line max" guidance.
- MEDIUM cmd/thv-proxyrunner/app/app.go (3267942342): same one-line fix;
  ExecuteContext returns nil on clean cobra exit.
- LOW cmd/thv-operator/main.go (3267942350): restore the package doc
  sentence ("It sets up and runs the controller manager...") dropped
  during the original move.
- LOW cmd/thv-proxyrunner/app/{entrypoint -> app}.go (3267942360): rename
  for cross-binary consistency with cmd/thv-operator/app/app.go.

Coverage Stats

0 of 271 new or added lines in 4 files covered. (0.0%)

2 existing lines in 1 file now uncovered.

64679 of 98715 relevant lines covered (65.52%)

62.83 hits per line