dcdpr / jp / 26170657135

66%

push

github

refactor(config): introduce `CommandConfig` and `shlex`-based parsing (#664)

Extract a generic `CommandConfig` / `CommandConfigOrString` type under
`jp_config::types::command`, replacing the tool-scoped
`ToolCommandConfig`. The new type lives at the config-types layer so it
can be shared by tools, labels, and any other consumer that needs to
model an external command.

String shorthands now use shell-word semantics via `shlex` instead of
`split_ascii_whitespace`. This means quoting is respected at
config-parse time, so `command = "nvim -c 'set ft=md'"` correctly passes
two arguments (`-c` and `set ft=md`) rather than three. Inputs with
unbalanced quotes are rejected at parse time rather than producing
garbage at spawn time.

The same `shlex`-based splitting is applied to `EditorConfig::command`
and `EditorConfig::path` when reading editor env-vars (`JP_EDITOR`,
`VISUAL`, `EDITOR`). Previously only the first whitespace-separated
token was used; now `JP_EDITOR="code --wait"` correctly invokes `code`
with `--wait` as an argument. Env-var values with unbalanced quoting are
skipped and the next variable in the list is tried instead.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

31 of 91 new or added lines in 5 files covered. (34.07%)

30166 of 46207 relevant lines covered (65.28%)

249.37 hits per line