vispy / vispy / 26163722511

75%

Build Type

push

github

Committed by web-flow

Commit Message

Set depth buffer for gridlines (#2748)

Currently the gridlines visual does not set the depth buffer. This is
not important in 2D, buut when using it in 3D the depth is set to a
plane parallel to the screen (cause of the impostor rendering as a
screen-covering quad). This PR sets the depth buffer correctly, so this
is no longer a problem.

Here's an example:

```py
from vispy import scene
import numpy as np

canvas = scene.SceneCanvas(show=True)

view = canvas.central_widget.add_view()
view.camera = 'arcball'
view.camera.scale_factor = 30

grid = scene.GridLines(parent=view.scene)
grid.transform = scene.STTransform(translate=(0, 0, -5))
grid.update_gl_state(preset='translucent')

cube = scene.Cube(size=10, parent=view.scene)
cube.transform = scene.STTransform(translate=(0, 0, 5))
cube.update_gl_state(preset='translucent')
```

On main, you'll see no cube, regardless of rotation, cause the grid wind
the depth test all the time. On this pr, the grid and cube exist in
space as expected.

<img width="802" height="602" alt="image"
src="https://github.com/user-attachments/assets/0141416f-420b-4890-b11e-79ac39663c4e"
/>

Coverage Stats

5933 of 10750 branches covered (55.19%)

24 of 24 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

24428 of 32598 relevant lines covered (74.94%)

2.45 hits per line