Qiskit / qiskit / 26154805533
88%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 941
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.477% (+0.007%) from 87.47%
26154805533

push

github

web-flow 
Remove unused dependencies from qasm2 and qpy crate (#16213)

* Remove unused dependencies from qasm2 and qpy crate

There were two unused dependencies in rust crates. The qiskit-qasm2
crate had an unused dependency on the qiskit-circuit crate. In an ideal
world the qasm2 parser would go directly from the qasm2 ast (or
equivalent) to the internal circuit api to build a circuit. But right
now it doesn't do that and exposes a bytecode to python which then
constructs the circuit. The qiskit-qpy crate was depending on the
oq3_semantics crate for some reason. Since this is a parser crate for
qasm3 which is independent from qpy I'm not sure why this was listed.
But it's not used anywhere in the qpy crate so it's safe to remove.

This removes both of these unused dependencies, unfortunately it doesn't
remove anything from the qiskit-pyext build as the removed dependencies
are still part of the overall build. But it at least cleans up the tree
a bit to better reflect. For the case of oq3_semantics it also removes a
place with a hardcoded version as it wasn't using a workspace specified
version which could have caused multiple versions if we bumped the
requirement in the future (assuming a future oq3_semantics release).

* Add missing PyO3 features

It looks like qiskit-circuit was being used by qiskit-qasm2 to
implicitly pull in the optional pyo3 features that qasm2 was using but
qiskit-circuit also enabled. This adds the missing pyo3 features so that
qiskit-qasm2 can be built in isolation.

107921 of 123371 relevant lines covered (87.48%)

950994.33 hits per line

Coverage Regressions

Lines Coverage ∆ File
11
73.93
 -0.41% crates/circuit/src/parameter/symbol_expr.rs
2
92.29
 0.0% crates/qasm2/src/lex.rs
Jobs
ID Job ID Ran Files Coverage
1 26154805533.1 941
87.48
 GitHub Action Run
Source Files on build 26154805533