opendefensecloud / solution-arsenal / 26148057266

72%

Build Type

push

github

Committed by web-flow

Commit Message

feat: solar client options (#507)

## What

Supports #497, tests and runtime need different SolarClient
initialization.

## Why
Tests were failing while migrating to GitHub CI Runners

## Testing
Local tests and E2E tests.

## Notes for reviewers
Find also [original
discussion](https://github.com/opendefensecloud/solution-arsenal/pull/497#pullrequestreview-4242152117)

## Checklist
- [X] Tests added/updated
- [X] No breaking changes (or upgrade path documented above)
- [X] Readable commit history (squashed and cleaned up as desired)
- [x] AI code review considered and comments resolved


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Refactor**
* Pipeline initialization now accepts an external Solar client so
discovery components are wired from a caller-provided client, improving
startup clarity and configuration alignment.
* **Bug Fixes**
* Prevents errors when no registry scanners are configured, improving
stability during discovery startup.
* **Tests**
* Updated pipeline tests to accommodate the new initialization approach
(including nil/fake clients).

<!-- review_stack_entry_start -->

[![Review Change
Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/opendefensecloud/solution-arsenal/pull/507?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)

<!-- review_stack_entry_end -->
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Coverage Stats

12 of 12 new or added lines in 1 file covered. (100.0%)

4 existing lines in 1 file now uncovered.

2385 of 3280 relevant lines covered (72.71%)

22.26 hits per line