dangernoodle-io / breadboard / 26142020425

100%

push

github

fix(bb_event_routes): guard s_topics[] and s_num_topics with a mutex (#281)

* fix(bb_event_routes): guard s_topics[] and s_num_topics with a mutex

- hold s_topics_lock across the full attach_ex operation instead of
  release/reacquire; bb_event_ring_attach_ex uses its own bb_event_lock
  so there is no deadlock risk
- eliminates the re-check-after-reacquire block and its two
  race-only branches (which were not reachable in tests and caused
  coveralls to report a branch-coverage regression)
- all other mutex guards (capture_cb, client_acquire_ex, drain_frame,
  topic_count, topic_info) unchanged

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(bb_event_routes): eliminate two dead-code branches to restore 100% branch coverage

- remove redundant `if (!s_topics_lock)` guard in init: unreachable because
  `s_cfg.initialized` gates re-entry; always allocate unconditionally
- remove defensive `else { topic_name[0] = '\0'; }` in drain_frame: capture_cb
  guarantees topic_idx is always in-range; the fallback was dead code

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

1024 of 1024 branches covered (100.0%)

Branch coverage included in aggregate %.

36 of 36 new or added lines in 1 file covered. (100.0%)

1896 of 1896 relevant lines covered (100.0%)

951.29 hits per line