raystack / frontier / 26141719376

43%

main: 43%

Pull #1630

github

fix(serviceuser): symmetric SpiceDB cleanup on delete

SU creation writes both Subject-side relations (e.g. platform sudo) and
Object-side relations (the serviceuser#org identity link). Delete only
swept the Subject side, so the identity-link tuple leaked whenever the
membership cascade was skipped — most commonly when the SU had no
remaining org policies at delete time, since RemoveOrganizationMember
returns ErrNotMember early and never reaches the cascade where that
cleanup lives.

Add an Object-side wildcard delete after the existing Subject-side one,
tolerating relation.ErrNotExist. Same shape as the policy.Delete fix.

Also add a mockery entry for core/serviceuser and seed unit coverage
for Service.Delete (happy path, membership-failure-swallowed path,
ErrNotExist tolerance, both failure short-circuit paths).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

8 of 8 new or added lines in 1 file covered. (100.0%)

16147 of 37945 relevant lines covered (42.55%)

11.91 hits per line