dangernoodle-io / breadboard / 26141107752

100%

push

github

fix(bb_wifi): fix five concurrency/safety bugs (audit 3.2, 3.3, 4.1, 7.1) (#280)

- bug 7.1: break the 30 s validated-firmware retry delay into 1 s
  chunks with esp_task_wdt_reset() to avoid tripping the 5 s task wdt
  that app_main is subscribed to by default in esp-idf v5.x
- bug 3.2 (part 1): make s_retry_count atomic_int; use atomic_load /
  atomic_store / atomic_fetch_add at all read/write sites
- bug 3.2 (part 2): add portMUX_TYPE s_ap_mux spinlock protecting
  s_cached_ssid, s_cached_bssid, and s_cached_rssi; wrap event-handler
  writes and bb_wifi_get_info / bb_wifi_get_rssi reads in
  portENTER_CRITICAL / portEXIT_CRITICAL
- bug 3.3: add atomic_thread_fence(memory_order_release) before
  s_cached_scan_count write in scan_worker_task and matching
  atomic_thread_fence(memory_order_acquire) before the count read in
  bb_wifi_scan_get_cached
- bug 4.1: capture bb_wifi_set_hostname return in bb_wifi_autoinit;
  log bb_log_w with error code on non-ok; continue rather than bail

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

1020 of 1020 branches covered (100.0%)

Branch coverage included in aggregate %.

1867 of 1867 relevant lines covered (100.0%)

965.33 hits per line