KarpelesLab / libwallet / 26130712648

22%

push

github

wltswap: Swap:maxSpendable returns advisory quotes instead of errors

Two soft-failure paths in Swap:maxSpendable used to surface as
errors — the wallet's spendable balance can't cover the network
fee + rent reservation, or the provider returned "no route" /
"Failed to get quotes" at the resolved amount (Jupiter's de-facto
floor on dust-sized SOL swaps). Hosts that build a "swap from"
list by filtering out assets whose maxSpendable errored ended up
hiding assets the user clearly owned: swap most of your SOL into
USDC, end up with 0.0061 SOL, and SOL disappears from the picker.

Both paths now return a Quote carrying a populated TokenIn / AmountIn
plus a non-empty QuoteStatus ("balance_too_small" / "no_route") and
a StatusMessage explaining the situation. AmountOut / MinAmountOut
are zero-valued (with correct decimals) so typed clients don't
trip on nulls; Route / providerBlob / QuoteId are deliberately
empty so Swap:execute will refuse them. Swap:quote and
Swap:quotes still error on no-route — the user is asking for a
specific trade and a silent no-route would mislead.

isNoRouteError recognises the canonical provider "no route"
substrings (Jupiter's "Failed to get quotes", 1inch's "no route",
dFlow's "no liquidity" / "insufficient liquidity"); other
ErrCodeProviderBadRequest surfaces still error out so genuine
caller bugs aren't downgraded.

The Dart SwapQuote model gains `status`, `statusMessage`, and an
`isExecutable` getter so hosts can branch on the soft signal
without inspecting placeholder zero-out values. CHANGELOG entry
under 0.4.35; pubspec stays at 0.4.34 until CI greens
(release-workflow rule).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

41 of 57 new or added lines in 1 file covered. (71.93%)

3798 of 17182 relevant lines covered (22.1%)

110.48 hits per line