ponder-lab / Hybridize-Functions-Refactoring / #1483

72%

push

travis-pro

Retire `*Exists` vocabulary from internal `Function` helpers (#517)

* Replace JavaBean-style `is*ParamExists` accessors with `has*Param` (#512)

Renames eight `*ParamExists` boolean fields + `is*ParamExists()`
accessors on `Function.HybridizationParameters` to natural Java
predicates of the form `has*Param`, both at the field and method level.
The doubled-predicate `is autograph param exists` reading is replaced
with `has autograph param`. Drops the unjustified `is*` JavaBean prefix
(no introspection, serialization, or DI on this class).

Field-level renames also fix a pre-existing typo: `experimenta` →
`experimental` in `experimentaFollowTypeHintsParamExists`; and normalize
`isExperimentalAutographOptParamExists` (abbreviated `Opt`) to
`hasExperimentalAutographOptionsParam` (matching the field's full word).

`getHasTensorParameter()` (a `Boolean` tri-state) is deliberately left
alone—the JavaBean convention forbids `is*` for `Boolean` (not
`boolean`), so the existing `get*` is consistent.

Closes #512

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Drop `has` prefix from `*Param` field names; keep on accessors

Per review feedback on #514, restores the noun-form-field +
predicate-form-accessor pattern (matching `tensor`/`isTensor()`
established in #511/#513): field `autoGraphParam` is the noun, accessor
`hasAutoGraphParam()` is the predicate. Removes the field/method name
collision and reads more idiomatically.

Same shape applied to all eight `*Param` fields. Method declarations
and external callers (Parameter.java, eval handler, test suite) are
unchanged—the accessor's public name was never the issue.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Retire `*Exists` vocabulary from `Function.HybridizationParameters` helpers

Renames the two internal helpers that still carried the legacy framing:

- `computeParameterExistance` (also fixes the misspelling) →
  `computeParameters`
- `markParamExists` → `markParam`

Both methods... (continued)

19 of 22 new or added lines in 2 files covered. (86.36%)

1192 of 1652 relevant lines covered (72.15%)

0.72 hits per line