stacklok / toolhive / 26116221449

66%

Build Type

push

github

Committed by web-flow

Commit Message

Use shared toolhive-core redis client for session storage (#5324)

pkg/transport/session carried its own Redis connection layer (RedisConfig,
SentinelConfig, RedisTLSConfig, validateRedisConfig, buildRedisClient,
buildRedisTLSConfig, timeout defaults). The auth-server migration in
#5318 demonstrated the pattern for replacing that duplicated code with
toolhive-core/redis; vmcp session storage and the proxy-runner session
storage are the remaining consumers in this repo.

Replace the local RedisConfig/SentinelConfig/RedisTLSConfig types and the
validate/build helpers with tcredis.Config and tcredis.NewClient.
NewRedisStorage and NewRedisSessionDataStorage now take
(ctx, tcredis.Config, keyPrefix, ttl); the constructors keep the
session-specific invariants (key prefix required, must end with ':',
ttl > 0) and delegate connection-mode validation, timeout defaults, TLS
plumbing, and Ping verification to the shared package.

NewManagerWithRedis grows the same keyPrefix parameter so the wrapper
matches the underlying storage signature. The vmcp server and proxy
runner call sites build tcredis.Config in place (Addr, Password, DB) and
pass keyPrefix separately; RedisPasswordEnvVar stays in the session
package because pkg/runner reads it.

Tests: TestValidateRedisConfig is removed (topology checks now live in
tcredis); TestNewRedisStorageInvariants replaces it with the
session-specific cases (key-prefix and ttl). TestNewRedisStorageACLAuth
keeps its coverage but uses the new signature. The "invalid TLS CA cert"
manager subtest is dropped (now exercising tcredis code).

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

21 of 32 new or added lines in 5 files covered. (65.63%)

3 existing lines in 2 files now uncovered.

64603 of 98677 relevant lines covered (65.47%)

61.86 hits per line