bitcoindevkit / bdk-sp / 26098264887

26%

push

github

Merge bitcoindevkit/bdk-sp#60: fix: scan-rpc ignores wallet birthday

d815fe617 fix(cli2): log start point at scan-rpc begin (GuiSchet)
1366db738 fix(cliv2): scan-rpc ignores wallet birthday (GuiSchet)

Pull request description:

  ### Description

  Closes #59.

  `scan-rpc` was constructing the `bdk_bitcoind_rpc::Emitter` with `start_height = 0`, so every invocation began emitting blocks from genesis and crawled the entire chain history regardless of the wallet's `birthday`.

  This change mirrors the logic that `scan-cbf` already implements.

  ### Notes to the reviewers

  No tests were added: there are no existing tests under `cli/v2/` and `just check` / `just test` are both configured to exclude `bdk_sp_cli_v2`.

  ### Execution trace

  Demo setup on signet:

  | | |
  |--|--|
  | chain tip height | `304930` |
  | wallet birthday height | `299930` (= tip − 5000) |
  | wallet birthday hash | `000000123dfc5a243bbdaca90dad2ce9b` |

  For each run a fresh DB was used (`sp-cli2 create --network signet --birthday-height 299930 --birthday-hash <hash>`), then `sp-cli2 scan-rpc` against a fully-synced local bitcoind. The CLI's existing periodic print reports `synced to <hash> @ <height>` — the `<height>` column is what tells us where the emitter is actually iterating.

  #### Before (`master`, `start_height = 0`)

  ```
  [  6.000065s] synced to 0000003844272e5d3b8b9c674a039e0a0 @ 11227 | total: 0 BTC
  [ 12.000166s] synced to 000000a332309572d95971b9f11d6aa43 @ 23166 | total: 0 BTC
  [ 18.000744s] synced to 000001181687ff908060ecf819fb93ddc @ 31798 | total: 0 BTC
  [ 24.016146s] synced to 000000159185041936b7f690348da32e8 @ 32513 | total: 0 BTC
  [ 30.038584s] synced to 00000116b95d06c1aad83247cdfb45034 @ 332... (continued)

74 of 94 branches covered (78.72%)

Branch coverage included in aggregate %.

0 of 5 new or added lines in 1 file covered. (0.0%)

819 of 3278 relevant lines covered (24.98%)

10.1 hits per line