gnosisguild / zodiac-core / 26095107740

96%

Build Type

push

github

Committed by web-flow

Commit Message

Audit Feedback (#35)

* Replace IGuard with IModuleGuard to align with Safe's ModuleGuard

* Return zero hash on invalid ecrecover signature for consistency with ERC1271 path

* Take signatures as explicit args and sign a typed EIP-712 ModuleTx struct

* Make the checker flow more straightforward:
- compute eip-712 hash once
- try eoa recovery first, when sig size matches 65 bytes
- continues to erc-1271 if the previous setup did not yield a signer

* Bump dependencies and upgrade to hardhat 3

* Fix ci test run

* Drop redundant zero-hash check in moduleOnlySigned

* Restore Solidity pragma in SignatureChecker to >=0.8.0 <0.9.0

* Remove unused imports

* Drop CJS dual build and emit ESM-only

* Bump package json version

---------

Co-authored-by: Cristóvão <cristovaoth@users.noreply.github.com>

Coverage Stats

167 of 171 new or added lines in 10 files covered. (97.66%)

9 existing lines in 2 files now uncovered.

440 of 459 relevant lines covered (95.86%)

0.96 hits per line