gnosisguild / zodiac-modifier-roles / 26094253852

88%

main: 96%

Pull #393

github

EIP-712 signing: typed allow* helpers and docs (#479)

* add docs on signature scoping

* rename scope* to allow* and return full permission objects

* sdk: rename local Encoding type to AbiTypeInput in matches.ts

Resolves a longstanding name clash with the `Encoding` enum imported from
zodiac-roles-deployments and unblocks downstream typechecking.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* sdk: type allowSignTypedMessage and encodeSignTypedMessage against TypedData

`allowSignTypedMessage` now accepts `domain` and `message` as
`StructScoping`s derived from the EIP-712 type tree, and
`encodeSignTypedMessage` requires the message to match the primary type's
fields. Wrong field names and wrong primitive types are caught at compile
time, with full autocomplete via `as const` `types`.

Shared type utilities live in `typedDataTypes.ts`. Drop the redundant
0x-cast on `SIGN_TYPED_MESSAGE_LIB_ADDRESS` and add proper JSDoc to the
allow helpers.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* sdk: add typings tests for allowSignTypedMessage and Scoping edge cases

Covers struct-shape inference, partial scopings, primary-type derivation,
and nested-struct field validation for the new typed `allowSignTypedMessage`.
Extends the `c.matches`/`Scoping` typings test with the unknown-field,
partial-scoping, and empty-object cases.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* integration-tests: use typed allowSignTypedMessage API

Drops the hand-rolled AbiEncoded condition blocks in favor of the new
struct scopings. Inlines EIP712Domain in `types` so TypedDataToPrimitiveTypes
can resolve literal field types. Types SomeAddress/AddressOne as 0x-strings
so they fit the inferred message shape.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs: rewrite SDK signing reference around the typed allowSignTypedMessage API

Replaces the c.abiEncodedMatches example with th... (continued)

660 of 754 branches covered (87.53%)

Branch coverage included in aggregate %.

1082 of 1229 relevant lines covered (88.04%)

840.84 hits per line