scriptype / writ-cms / 26069760055

38%

push

github

Fix post<->attachment circular referencing in CMS

Because attachments lack a schema, the legacy logic of pushing a
backlink into links.relations is triggered. And 'links' was not omitted
in CMS http responses. So, omit it.

This issue could be reproduced by linking to anything lacking a schema
in a node's own subtree.

The deeper issue is the confusing existence of the legacy backlinking
logic. Once it's removed, the funny possibility of a schemaless node
causing a runtime circular referencing error if another node linked to
it.

642 of 3730 branches covered (17.21%)

Branch coverage included in aggregate %.

0 of 1 new or added line in 1 file covered. (0.0%)

2230 of 3749 relevant lines covered (59.48%)

1141.62 hits per line