umputun / ralphex / 26064022328

83%

master: 83%

Build Type

Pull #350

github

Committed by umputun

Commit Message

fix(codex): harden backward compatibility for default-claude users

Code-review-plus + codex GPT-5 + Copilot identified 17 places where the
first-class --codex work silently altered behavior for users running without
--codex. Each change here scopes new behavior to the opt-in --codex path and
preserves master semantics for the default-claude pipeline.

Critical
- runReview no longer aborts the run on first-review session/idle timeout
  for default-claude users (master logged a soft warning and continued).
  Gated on cfg.isCodexExecutor() — only --codex treats the timeout as fatal
  (load-bearing under --codex because external review is auto-skipped).
  Phase label parameterized so the warning/error text is accurate if the
  helper is reused.
- progress.Logger writes are now serialized through l.writeMu held across
  each public method's full file + stdout pair (writeTimestamped, PrintRaw,
  PrintSection, PrintAligned per-line, LogQuestion, LogDraftReview, Close).
  processStderr and the new tailRolloutFile both call OutputHandler from
  separate goroutines; without the mutex a concurrent producer could slip
  between a method's two sinks and split related output (file gets producer
  A while stdout shows B, or LogQuestion's QUESTION line gets separated
  from its companion OPTIONS line). writeFile/writeStdout renamed to
  *Locked to make the contract explicit.

High (backward-compat regressions)
- execCodexRunner.childEnv now scopes ANTHROPIC_API_KEY stripping to
  first-class --codex via a stripAnthropicKey flag wired to MultiAgent.
  External codex review in default-claude mode preserves the host env so
  custom codex wrappers proxying through Anthropic (scripts/codex-as-claude.sh)
  keep authenticating. CLAUDECODE is always stripped.
- codex_model = gpt-5.5 and codex_reasoning_effort = xhigh restored as
  active embedded defaults; commenting out the lines is the user opt-in
  for inheriting from ~/.codex/config.toml. Previous commented-out defaults... (continued)

Pull Request Pull Request #350: Add first-class codex executor mode

Coverage Stats

599 of 667 new or added lines in 9 files covered. (89.81%)

17 existing lines in 4 files now uncovered.

7382 of 8883 relevant lines covered (83.1%)

231.41 hits per line