475
98%

Ran 19 Sep 2016 05:40PM UTC

Jobs 8

Files 1022

Run time 5min

Badge

Embed ▾

pending completion

Build # 475

Build Type

Pull #170

travis-ci

Committed by

web-flow

Commit Message

Fix image_v2 update and identity

- This removes the workaround which always set `identity` to nil for image_v2 models
  - This fixes methods such as `reload` which rely on a valid identity
- Update `save` to call `create` in the `self` attribute is not present, otherwise call `update`
- if `update` is not passed any args, it will pull current object values from the server to
  construct the json PATCH
  - This is more consistent with the `update` API elsewhere in the codebase
- Update identity_v3_spec to use VCR variables if `use_recorded` is true
  - Made all config variables in `shared_context` attr_readers so they could be referenced in other spec files
  - Before this change, this test would attempt to hit real endpoints if any
    `OS_` environment variables were set, even if `use_recorded` was true
- Mark several environment variables as required in image_v2_upload_spec
  - Since this test always needs to run against a real endpoint, we shouldn't default
    username and password to dummy values as it will cause a more confusing failure later on
  - Also swap `eq` for `must_equal` to be more consistent with rest of the codebase

Signed-off-by: Brian Cunnie <bcunnie@pivotal.io>

Pull Request Pull Request #170: Make image_v2 models more consistent with Fog API

Run Details

16373 of 17562 relevant lines covered (93.23%)

57.32 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	475.1 (JRUBY_OPTS=--debug)	19 Sep 2016 05:40PM UTC	93.89	Travis Job 475.1
2	475.2 (1.9.3, JRUBY_OPTS=--debug, gemfiles/Gemfile-1.9)	19 Sep 2016 05:41PM UTC	93.89	Travis Job 475.2
3	475.3 (2.0.0, JRUBY_OPTS=--debug, Gemfile)	19 Sep 2016 05:40PM UTC	93.89	Travis Job 475.3
4	475.4 (2.1.0, JRUBY_OPTS=--debug, Gemfile)	19 Sep 2016 05:41PM UTC	93.89	Travis Job 475.4
5	475.5 (2.1.1, JRUBY_OPTS=--debug, Gemfile)	19 Sep 2016 05:41PM UTC	93.89	Travis Job 475.5
6	475.6 (2.2.0, JRUBY_OPTS=--debug, Gemfile)	19 Sep 2016 05:42PM UTC	93.88	Travis Job 475.6
7	475.7 (2.3.0, JRUBY_OPTS=--debug, Gemfile)	19 Sep 2016 05:42PM UTC	93.89	Travis Job 475.7
8	475.8 (jruby-19mode, JRUBY_OPTS=--debug, gemfiles/Gemfile-1.9)	19 Sep 2016 05:44PM UTC	93.46	Travis Job 475.8

Source Files on build 475

Detailed source file information is not available for this build.

fog / fog-openstack / 475
98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 475

fog / fog-openstack / 475 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 475

fog / fog-openstack / 475
98%

README BADGES
x