dcdpr / jp / 26055214511

66%

push

github

fix(cli): Fix printing of flattened nested lists and maps (#656)

`pre_render_for_prompt` was gated entirely on `FormatMode::Unattended`,
which meant tools using `Json`, or `FunctionCall` parameter styles would
not show the tool call arguments before the approval prompt whenever
`run = "ask"`, unless `format = "unattended"` was set.

`FormatMode::Ask` exists solely to defer side-effecting *custom*
formatters (user-controlled shell commands) until after the user has
approved the call. Built-in styles are pure transformations with no side
effects, so deferring them serves no safety purpose and actively harms
the UX: the user cannot make an informed approval decision without
seeing the call arguments.

The fix changes the pre-render gate to branch on `ParametersStyle`:
`Custom` still respects `FormatMode`; `Json`, `FunctionCall`, and `Off`
always pre-render regardless of `format_mode`.

Doc comments on `ToolsDefaultsConfig::format` and `ToolConfig::format`
are updated to state clearly that the field only affects
`ParametersStyle::Custom`.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

10 of 10 new or added lines in 1 file covered. (100.0%)

26950 of 41475 relevant lines covered (64.98%)

207.62 hits per line