go-sql-driver / mysql / 26049486255

83%

master: 83%

Build Type

Pull #1770

github

Committed by c-tonneslan

Commit Message

dsn: default Net to 'tcp' in NewConfig so Addr-only configs round-trip

Closes #1616.

NewConfig() left Net empty, so building a Config in code with just an
Addr and calling FormatDSN produced '/' (no tcp prefix, no address)
instead of 'tcp(my-address)/'. Default Net to 'tcp' to match the docs,
and skip the bare protocol in FormatDSN when there's no Addr so a
fresh NewConfig().FormatDSN() doesn't grow a useless 'tcp' prefix.

Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>

Pull Request Pull Request #1770: dsn: default Net to tcp in NewConfig so Addr-only configs round-trip

Coverage Stats

7 of 0 new or added lines in 0 files covered. (NaN%)

53 existing lines in 1 file now uncovered.

3380 of 4087 relevant lines covered (82.7%)

2624280.45 hits per line