divviup / divviup-api / 26052175204

69%

Build Type

push

github

Committed by web-flow

Commit Message

Migrate from Trillium [part 9A]: Replace trillium_client with reqwest (#2265)

* Migrate from Trillium [part 9A]: Replace trillium_client with reqwest

Replace `trillium_client::Client` with a new `HttpClient` wrapper around
`reqwest::Client` that provides the same `with_base()`/`with_default_header()`
API surface the codebase relied on.

Key changes:
- OAuth2 flow now uses oauth2 crate's native reqwest support, eliminating the
  manual `ClientWrapper` that converted between trillium and http types
- `JobError` fields changed from `trillium::Method`/`Status` (which had serde
  support) to `String`/`Option<u16>` for serialization compatibility
- `bin.rs` crypto provider switched from `trillium_rustls::rustls` re-export
  to direct `rustls` dependency, since Tim pointed that out last review
- test-support bridged to start a real TCP mock server and point reqwest at it
- with_base() now appends a trailing slash (matching trillium_client
  behavior) so that Url::join works correctly with path prefixes
- OriginRouter switches to host-only matching (scheme-agnostic) since
  the mock server runs plain HTTP while clients use HTTPS base URLs

HttpClient gains a proxy_base field: when set, all outgoing requests
have their scheme+host+port rewritten to the proxy address while the
original host is preserved in the Host header. This lets tests point
every client at a single mock server that dispatches by Host.

An X-Original-URL header carries the pre-rewrite URL so that
ClientLogs can reconstruct the intended URL for test assertions.

Coverage Stats

213 of 263 new or added lines in 19 files covered. (80.99%)

6 existing lines in 4 files now uncovered.

4460 of 7513 relevant lines covered (59.36%)

66.6 hits per line