valksor / kvelmo / 26040674470

84%

push

github

Quiet React Compiler false-positives in load/poll useEffect sites

bun run lint was failing with 31 errors after a recent dependency
bump enabled the React Compiler (eslint-plugin-react-hooks /
eslint-plugin-react-compiler) lint family. None of the errors were
introduced by recent work — confirmed via git stash + lint repro on
the parent commit. Per the project rule ("Fix ALL errors and
failures in the output, not just ones you introduced") this commit
addresses them.

Breakdown of the 31 failures and how each was handled:

bun run lint --fix auto-fix (9 errors)

- @typescript-eslint/no-unnecessary-type-assertion in
  FieldRenderer.tsx, export.test.ts, browserStore.test.ts,
  chatStore.test.ts: stale `as Foo` assertions on values whose
  inferred type already matches.

One follow-up to the auto-fix (1 error)

- web/src/components/settings/FieldRenderer.tsx: removing the
  String(value) wrapper triggered @typescript-eslint/no-base-to-
  string because value is `unknown`. Replaced with a type-narrowed
  conversion: only String() when value is already string|number,
  empty otherwise.

eslint-disable-next-line with per-line justification (20 errors)

- 18 components, 20 sites flagged by react-hooks/set-state-in-
  effect. Every site is the load-on-mount or polling idiom
  `useEffect(() => { void asyncFn() }, [deps])` where the
  setState calls live inside the async callback, not synchronous
  in the effect body. The rule fires conservatively because the
  compiler treats any setState reachable from an effect as
  problematic. Justification on each line:
  "load/poll idiom: setState lives in the async callback, not
  synchronous in the effect body".
- Components touched: ActivityPanel, AgentPanel, BackupPanel,
  BrowserPanel (2 sites), CIStatusPanel, CatalogPanel,
  ChecklistWidget, DiagnosePanel, EventLogPanel, FilePicker,
  FolderPicker, HooksPanel, MetricsPanel, PolicyPanel,
  QualityPanel, RecordingsPanel, Settings (2 sites), TaskHistory.

eslint-disa... (continued)

2818 of 4044 branches covered (69.68%)

Branch coverage included in aggregate %.

28594 of 57228 relevant lines covered (49.97%)

1.78 hits per line