wboayue / rust-ibapi / 26015956171

92%

Build Type

push

github

Committed by web-flow

Commit Message

errors: cursor EOF + unexpected response + decoder mismatch sites (#589)

* errors: cursor EOF + unexpected response + decoder mismatch sites

PR-5 of plans/error-variants-audit.md. Three families:

- 13 cursor peek_*/next_* EOF in messages.rs: Error::Simple → Error::Parse
  (keeps field index that Simple lost; no wrapper change at line 1155)
- 7 wrong-message-type sites with ResponseMessage in scope (contracts
  matching_symbols, display_groups decoder, accounts AccountUpdate
  catch-all): → Error::unexpected_response(message)
- 2 missing-market-depth-data sites (no ResponseMessage): →
  Error::UnexpectedResponse(...)
- 6 contract / option-computation None-channel sites: → UnexpectedEndOfStream
  (reclassified from "unexpected response" — structurally EOS, not wrong shape)
- 6 realtime decoder protocol mismatches (tick_type / HistoricalTick*):
  → Error::parse_field / Error::parse_proto
- 1 async shared-channel dispatch: → Error::InvalidArgument

Downstream test fixtures updated to match-on-variant; substring-based
realtime decoder tests still pass under preserved Display formats.

* errors: /simplify pass — eof_at helper, dead Simple arm, market_depth proto

- Add Error::eof_at(i, label) factory in errors.rs sibling to
  parse_field/parse_proto; collapse 11 cursor bounds-check sites in
  messages.rs to one-liners (4 sites flatten out of multi-line wrapping)
- Drop dead `| Error::Simple(_)` arm from the next_date_time_with_timezone
  wrapper at messages.rs:1165 — parse_ib_date_time_with_timezone only
  returns Error::Parse(0, ...) via parse_field; Simple arm was unreachable
- Reclassify market_depth_data missing-payload sites (lines 307/321) from
  Error::UnexpectedResponse → Error::parse_proto("market_depth_data",
  "missing in MarketDepth") to match sibling tick decoders in the same
  file (decode_trade/bid_ask/mid_point_tick_proto) migrated in this PR
  to parse_proto for the same "missing oneof in envelope" shape

Test fixture for decode_market_d... (continued)

Coverage Stats

43 of 46 new or added lines in 7 files covered. (93.48%)

1 existing line in 1 file now uncovered.

18987 of 20611 relevant lines covered (92.12%)

27.3 hits per line