wboayue / rust-ibapi / 26013932539

92%

Build Type

push

github

Committed by web-flow

Commit Message

errors: datetime + message-type parse sites → Error::Parse (#587)

* errors: datetime + message-type parse sites → Error::Parse

PR-4 of plans/error-variants-audit.md (18 sites + 2 new constructors).

Add `Error::parse_field` / `Error::parse_proto` factories (resolution
of parent §5.3 Option 4): keep the `Parse(usize, String, String)`
tuple shape, but encapsulate the placeholder `0` in named
constructors so call sites don't have to remember the convention and
a future shape change (Option<usize> or struct variant) absorbs in
one place.

Conversions (per plan):
- messages.rs:403,753,754 — IncomingMessages / OutgoingMessages
  FromStr "Unknown/Invalid X message type" → Error::parse_field.
- messages.rs:1344,1364,1367,1373,1377 — parse_ib_date_time_with_timezone
  and resolve_primitive_date_time → Error::parse_field.
- accounts/common/decoders/mod.rs:257,263,273,278 — proto path uses
  Error::parse_proto("current_time" / "current_time_in_millis", ...),
  text path uses Error::parse_field on the parsed timestamp.
- news/common/decoders.rs parse_unix_timestamp — both ParseInt and
  from_unix_timestamp failures → Error::parse_field. Also folded the
  trailing match into a single map_err chain.
- market_data/historical/common/decoders/mod.rs parse_unix_seconds_str /
  parse_date_with_tz / parse_bar_date — all 4 sites → Error::parse_field.

No test fixture or pattern-match updates needed: the cursor wrapper at
messages.rs:1155 already re-wraps Simple|Parse → Parse(self.i, ...),
and accounts/{sync,async}/tests.rs match arms already accept
Error::Parse.

* errors(test): dedupe parse_unix_seconds_str err-builder closure

Two identical Error::parse_field(s, format!("invalid unix-second
timestamp: {e}")) closures collapsed into a shared
mk_err: &dyn Display -> Error local. Caught by /simplify on PR-4.

Coverage Stats

25 of 34 new or added lines in 5 files covered. (73.53%)

21 existing lines in 4 files now uncovered.

18980 of 20607 relevant lines covered (92.1%)

27.33 hits per line