lsm / neokai / 26009933549

push

github

Add Space-native goal backend (#1908)

* feat: add space-native goal MVP backend (rebased onto dev)

Rebase onto dev after #1924 (Neo agent removal) and #1922 (task-agent
LLM helper removal). Squashes all prior goal commits into a single
clean commit on top of current dev.

- Space goals table, repository, service, RPC handlers
- Goal-task-schedule linkage (goal_id on space_tasks/task_schedules)
- Public/internal type split (goalId stripped from public RPC)
- Rolling goal state (summary, progress, metrics, nextSteps)
- autoTriggerNext with pendingNextRun queue
- Best-effort goal terminal handling in task completion paths
- Schedule service public/internal create split for goalId security
- completedAt preservation on archived goal edits
- Add missing SpaceTaskRepository.listActive() method

* fix: add space_goals to scope config and bootstrap schema

- Add space_goals to SPACE_SCOPE_TABLES for agent DB query access
- Fix bootstrap schema to use dev's base (no neo tables) + space_goals
- Update scope-config test to include space_goals in space scope

* fix: wire goal terminal handling through all task transition paths

Reviewer feedback (PR #1908 round 4):

- Add 'blocked' to TERMINAL_TASK_STATUSES for goal terminal handling
- Pass goalService to TASK_SCHEDULE_FIRE handler in app.ts
- Add goalService to PostApprovalRouter for no-route task completions
- Thread goalService through SpaceRuntimeConfig → SpaceRuntimeServiceConfig
- Update migration-45 test: M131 re-adds goal_id index to space_tasks

* fix: align migrations with dev — migration 128 external events, migration 66 neo guard

- Replace old migration 128 with dev's version that creates
  external_event_extension_configs (with legacy data migration) instead of
  the old external_event_source_configs table
- Add early-return guard to migration 66: skip when sessions CHECK already
  lacks 'neo' (prevents stale rebuild on post-M131 databases)
- Update migration-51 test: M131 re-adds goal_id index to... (continued)

8325 of 11892 branches covered (70.01%)

Branch coverage included in aggregate %.

1272 of 1372 new or added lines in 24 files covered. (92.71%)

67835 of 79669 relevant lines covered (85.15%)

300.25 hits per line