dangernoodle-io / breadboard / 25976226245

100%

push

github

fix(bb_nv): compare against ESP_ERR_NVS_NOT_FOUND, not BB_ERR_NOT_FOUND (#234)

#221 changed BB_ERR_NOT_FOUND from ESP_ERR_NVS_NOT_FOUND (0x1102) to
the generic ESP_ERR_NOT_FOUND (0x105) so it could be used outside
NVS contexts and compile on chips where nvs.h isn't transitively
pulled in. But bb_nv.c still calls nvs_get_*/nvs_open which return
ESP_ERR_NVS_NOT_FOUND. The 14 "key absent → fall back to default"
branches in bb_nv.c compared the nvs return value against the new
generic BB_ERR_NOT_FOUND — that comparison silently failed for every
absent-key lookup, and the unmapped ESP_ERR_NVS_NOT_FOUND propagated
to callers, where TaipanMiner's BB_ERROR_CHECK aborted.

Field impact: every production tdongle-s3 panicked within seconds to
minutes of booting the firmware that bundled v0.31.0; OTA validator
auto-reverted them to the prior release. Bitaxe-650 escaped because
its NVS was freshly populated by re-provisioning, so no absent-key
branch fired.

Fix is localized: bb_nv knows it's calling NVS, so compare the
returned esp_err_t against ESP_ERR_NVS_NOT_FOUND directly. Keeps
#221's intent (BB_ERR_NOT_FOUND stays generic for non-NVS callers).

Verified live on TaipanMiner tdongle-s3 .78 and .95 — both stable
>2min on the rebuilt firmware (previous build aborted at ~70s).

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

752 of 752 branches covered (100.0%)

Branch coverage included in aggregate %.

1340 of 1340 relevant lines covered (100.0%)

1110.14 hits per line