rm-hull / github-oauth-proxy / 25966251041

64%

push

github

refactor: port to golang (#144)

* refactor: port to golang

* fix: resolve linting issues regarding unused errors

- Ignore returned error from `healthcheck.New` as it is not needed.
- Assert `json.Unmarshal` error in `TestServer` to improve test
  reliability.
- Properly handle `resp.Body.Close()` error in `ExchangeToken` to
  satisfy linter requirements.

* chore: remove arm64 support from build workflow

* Removed QEMU setup action.
* Restricted build platform to `linux/amd64` to simplify CI and reduce
  build times.

* feat: add custom request logger middleware

- Replace default gin logger with a custom `zerolog` middleware.
- Improve log readability by using `time.RFC3339` timestamps.
- Add support for excluding specific paths (e.g., `/healthz`,
`/metrics`)
  to reduce log noise.
- Update `.gitignore` to ignore temporary debug binaries.

* Update internal/github/client.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* feat: improve github client robustness and logging

- Add error handling for non-200 responses in `ExchangeToken`.
- Set `User-Agent` for GitHub API requests.
- Use `zerolog.Ctx` in middleware for contextual logging.
- Add unit tests for `ExchangeToken` and `Logger` middleware.

```mermaid
sequenceDiagram
    participant C as Client
    participant GH as GitHub API
    C->>GH: POST /login/oauth/access_token
    alt 200 OK
        GH-->>C: Token Response
    else 4xx/5xx Error
        GH-->>C: Error JSON/Status
        C-->>C: Handle/Wrap Error
    end
```

* test: add unit tests for configuration loading

Adds comprehensive test coverage for `Load()` in the `config` package to
ensure correct handling of environment variables, specifically:
* Validation of required environment variables.
* Proper parsing of `GITHUB_OAUTH_SECRET_*` keys.
* Error handling for malformed input or missing requirements.

* refactor: simplify IsOriginAllowed using slices

Replace manual loop with `... (continued)

177 of 275 new or added lines in 7 files covered. (64.36%)

177 of 275 relevant lines covered (64.36%)

0.7 hits per line