lean-poker / boardgame.io / 25965437903

100%

push

github

fix(scripts): make test:coverage actually collect coverage under pnpm

Background: under pnpm 10, `pnpm test -- --coverage` forwards the `--`
literally, so jest sees `jest -- --coverage --collectCoverageFrom=src/**`
and treats everything past `--` as a testPathPattern. It then prints
`Invalid testPattern ... supplied. Running all tests instead.` — coverage
is silently dropped. CI's coveralls step has therefore been getting an
empty (or stale) lcov since the pnpm migration.

Fix: invoke jest directly in test:coverage and test:watch instead of
re-entering via pnpm test. Keep the lint guard for test:coverage by
chaining `pnpm run lint &&` explicitly (the `pretest` hook only fires
for `test`, not for test:coverage). test:watch skips lint to keep
iteration fast, matching the previous behaviour.

Verified: pnpm run test:coverage now emits lcov and reports per-file
coverage. (Note: a pre-existing flake in api.test.ts surfaced once under
parallel coverage — sibling-describe state leak around the deprecated
/rename endpoint. Separately filed.)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

1786 of 1789 branches covered (99.83%)

Branch coverage included in aggregate %.

2669 of 2673 relevant lines covered (99.85%)

28563.98 hits per line