accordproject / template-engine / 25955341741

64%

push

github

fix: draft() throws when {{#ulist}}/{{#olist}} contains direct variable references (#145) (#148)

When a `{{#ulist}}` / `{{#olist}}` body contains direct variable references
(e.g. `{{volumeAbove}}`) with no leading list marker (`- ` or `1. `), the
markdown parser does not wrap the body in a CommonMark `List > Item`
structure — it produces a `Paragraph` directly under the
`ListBlockDefinition`. The existing recursion in `generateRecursiveBlocks`
blindly accessed `context.nodes[0].nodes[0]`, which assumed the
`List > Item` wrapping. With the wrapping absent, that path pointed at a
leaf node (a `VariableDefinition` or `Text`), and `generateAgreement` was
then called with a `VariableDefinition` as its root `templateMark`. The
traversal visited the root with an empty `this.path`, so `getJsonPath`
threw `Error: Paths must be supplied`. When the first inline node was a
`Text` rather than a `VariableDefinition`, no error was thrown but each
output `Item` was silently empty.

Detect whether the parser produced a `CommonMark.List` wrapper and pick
the per-iteration template accordingly: when wrapped, descend into
`firstChild.nodes[0]` (the `Item` template) and unwrap its children into
each new output `Item` (preserving existing behaviour). Otherwise treat
`firstChild` itself as the per-iteration template and wrap the processed
block as the sole child of each new output `Item`, which keeps a valid
`Item > Paragraph > inline...` hierarchy.

Adds two snapshot-based fixtures (`volumediscountulist`,
`volumediscountolist`) and three assertion-based regression tests that
cover both failure modes (variable as the first inline node, and a
leading text inline node).

Signed-off-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>

355 of 548 branches covered (64.78%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

723 of 1132 relevant lines covered (63.87%)

6094.41 hits per line