electron / fiddle / 25948527416

89%

push

github

refactor: use more production code, fewer mocks in github tests (#1943)

* refactor: extract GIST_MAX_FILE_SIZE / GIST_MAX_FILE_COUNT constants

Hoist the gist size/count limits out of `src/main/github.ts` into `src/constants.ts` so tests can reference them by name instead of duplicating the magic numbers.

* refactor: STATIC_DIR in main/constants.ts now works in both production and tests

* test: add electron app.setPath() mock

* refactor: reduce scope of MOCK_GIST_FILES, MOCK_GIST_DATA

* refactor: remove magic string from github.spec.ts

* test: use more production code, fewer mocks in github.spec.ts

* test: stop mocking getTemplate() in github.spec.ts

* refactor: minor copyediting

* Apply suggestion from @dsanders11

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>

* test: safeguard tests against the credentials file location changing

* fixup! Apply suggestion from @dsanders11

* fix: unused variable warning

* fixup! test: safeguard tests against the credentials file location changing

fix: oops, removed a line accidentally

---------

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>

562 of 622 branches covered (90.35%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 3 files covered. (100.0%)

3554 of 4027 relevant lines covered (88.25%)

46.57 hits per line