yitsushi / totp-cli / 25943568760

56%

master: 20%

Build Type

Pull #150

github

Committed by yitsushi

Commit Message

fix: address potential bugs found in code review

Bug fixes:
- import: pass empty namespace to AddNamespace so accounts from new
  namespaces are not mistakenly treated as conflicts, causing spurious
  overwrite prompts
- set-length: validate ParseUint result and re-prompt on non-numeric
  input instead of silently storing length=0
- cmd: propagate terminal read errors from all askFor* helpers to
  prevent infinite loops on EOF/pipe close (add_token, set_length,
  set_prefix, rename, instant)
- generateCode: return error instead of printing to stdout so callers
  can surface failures rather than displaying an empty token
- CheckPasswordConfirm: use crypto/subtle.ConstantTimeCompare to avoid
  timing side-channel

Refactoring for testability:
- terminal: extract Terminal interface; New() returns *ConcreteTerminal
- storage: add PasswordProvider interface + StaticPasswordProvider;
  FileBackend accepts provider via WithPasswordProvider option
- cmd: extract execute*/askFor* functions with injected Terminal and
  Storage dependencies; add prepareStorage helper

Linter:
- replace deprecated wsl with wsl_v5, gomodguard with gomodguard_v2
- fix all noinlineerr and wsl_v5 violations; update quality-check action

Tests (overall coverage 22% → 63%):
- internal/cmd: add_token, change_password, delete, dump, error types,
  generate, import, list, rename, set_length, set_prefix, update
- internal/security/algo: SHA1/SHA256/SHA512/Default Hasher (0% → 100%)
- internal/security: OTPError.Error (97% → 100%)
- internal/storage: error types, SetPassword, acquirePassword branches

Signed-off-by: Victoria Nadasdi <victoria@efertone.me>

Pull Request Pull Request #150: fix: address potential bugs found in code review

Coverage Stats

284 of 428 new or added lines in 19 files covered. (66.36%)

4 existing lines in 3 files now uncovered.

674 of 1214 relevant lines covered (55.52%)

4.11 hits per line