Alan-Jowett / sonde / 25939302573

81%

push

github

fix: replace hardcoded login.microsoftonline.com with configurable login_endpoint (#926)

The OAuth token endpoint in uild_storage_queue_credential() was
hardcoded to login.microsoftonline.com, preventing the Azure
companion from working in sovereign clouds (Government, China, etc.).

Changes:
- Add loginEndpoint to Bicep companionBootstrapValues output from
  nvironment().authentication.loginEndpoint
- Add optional login_endpoint field to ServicePrincipalStateFile
  (backward-compatible: absent defaults to public cloud)
- Add required login_endpoint to BicepBootstrapValues (new
  deployments always populate it)
- Normalize trailing slashes and reject empty/whitespace values
- Use untime_state.login_endpoint in token endpoint construction
- Update specs: AZC-0305, AZC-0403, AZP-0203, design docs, and
  validation (T-AZC-0113, T-AZC-0305-2/3/4, T-AZC-0403)
- Add 10 new/updated tests (62 total, all passing)

Closes #921

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

110 of 110 new or added lines in 1 file covered. (100.0%)

34395 of 41393 relevant lines covered (83.09%)

193.88 hits per line