valkyrjaio / valkyrja-php / 25938570583

100%

push

github

[Application] Convert providers to instance-based contracts (#806)

# Description

Converts all `ComponentProviderContract` and `ServiceProviderContract`
methods across every module from static to instance, enabling providers
to hold state and be passed as objects. Replaces the single-level
provider expansion in `Valkyrja::getProviders()` with depth-first
recursive expansion via `collectProviders()`, so sub-providers are
always registered before the provider that depends on them. Renames
`ContainerData`'s `deferredCallback` parameter to `callbacks`. Removes
the now-redundant `PublishableComponentProviderContract`. Updates
`WhoopsThrowableHandler::enable()` to an instance method and adds
`ThrowableFactory`. Adds `@psalm-suppress
MoreSpecificImplementedParamType` to `NativeChildContainer::has()` to
match the existing suppress on the parent `Container`.

---

## Types of Changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

---

## Changes

- **`ComponentProviderContract`** — all methods
(`getComponentProviders`, `getContainerProviders`, `getEventProviders`,
`getCliProviders`, `getHttpProviders`) changed from static to instance
- **`ServiceProviderContract`** / **`ListenerProviderContract`** /
**`CliRouteProviderContract`** / **`HttpRouteProviderContract`** —
`publishers()` / `getRoutes()` / `getControllerClasses()` changed from
static to instance
- **`PublishableComponentProviderContract`** — deleted; functionality
consolidated into `ComponentProviderContract`
- **`Valkyrja::getProviders()`** — replaced single-level expansion with
recursive `collectProviders()` helper for depth-first post-order
traversal; no deduplication
- **... (continued)

512 of 516 new or added lines in 74 files covered. (99.22%)

12490 of 12496 relevant lines covered (99.95%)

15.51 hits per line