nats-io / nats.go / 25926277339

85%

Build Type

push

github

Committed by web-flow

Commit Message

[FIXED] Reject keys with consecutive dots in keyValid and searchKeyValid (#2076)

* kv: reject keys with consecutive dots in keyValid and searchKeyValid

Keys like "foo..bar" contain an empty token (two adjacent dots), which
makes them invalid NATS subjects. Both keyValid and searchKeyValid only
checked for a leading or trailing dot, so "foo..bar" would pass client-
side validation and reach the server, where it fails with a misleading
"nats: jetstream not enabled" error instead of a clear key validation
error.

Add a strings.Contains(key, "..") check to both functions in the legacy
kv.go and in jetstream/kv.go so these keys are rejected early with
ErrInvalidKey. Add test cases for Watch with consecutive-dot patterns.

Fixes #1354

Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>

Coverage Stats

4 of 4 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

14737 of 17248 relevant lines covered (85.44%)

32355.51 hits per line