kubeflow / trainer / 25925865057
62%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 40
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 62.134%. Remained the same
25925865057

push

github

web-flow 
feat: KEP for inject PET envs into init-container (#3417)

* docs(proposals): add draft KEP for inject PET envs into trainer init containers

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* fix comments

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* address comments

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* Add OPT-In annotation

Polish more

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* add more detailed user story

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* change annotation name to more generic

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* docs(proposals): clarify plugin env injection mode in KEP-3416

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* docs(proposals): switch from annotation to TorchMLPolicy API field for env injection

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* docs(proposals): clarify envInjection default state semantics

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* docs(proposals): refine envInjection API to use initContainers name list

Replace containerTypes enum with explicit initContainers []string for
precise targeting. The main container (node) always receives PET_* envs,
eliminating the need for container type distinction and extra validation.

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* docs(proposals): adopt targets/jobName/containerNames API per review consensus

Use explicit targets list with jobName and containerNames for declarative
API. Main container (node) always injected automatically. jobName chosen
over replicatedJobName for future CRD compatibility (LWS, Grove, Slurm).

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* docs(proposals): fix stale text to align with targets API

Proposal description, Goal, and Non-Goals previously referenced
trainer init containers only. With the targets/jobName/containerNames
API, injection targets any container in any replicated job.

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* docs(proposals): fina... (continued)

2184 of 3515 relevant lines covered (62.13%)

0.72 hits per line

Jobs
ID Job ID Ran Files Coverage
1 25925865057.1 40
62.13
 GitHub Action Run
Source Files on build 25925865057