pashagolub / pgxmock / 25912613469

94%

push

github

[-] return non-nil errRows from Query on failure, fixes #258 (#259)

pgx's `pool.Query` returns an `errRows` sentinel (not nil) when a query
fails, so callers can safely pass the rows value to `pgx.CollectRows` &
`pgx.CollectOneRow` without first nil-checking it.

pgxmock was returning nil rows on any `Query` error, causing a nil-pointer
panic when code followed that pattern.

Add an `errRows` type that implements `pgx.Rows` and surfaces the error
through every method. Query now returns `&errRows{err}` instead of nil
when no matching expectation is found or an expectation returns an error.

Add `TestIssue258QueryReturnsErrRowsOnFailure` to reproduce the panic and
confirm the fix.

12 of 12 new or added lines in 2 files covered. (100.0%)

842 of 894 relevant lines covered (94.18%)

1.09 hits per line