kubeovn / kube-ovn / 25909114514

26%

push

github

fix(ipam): roll back partial state when random allocation fails (#6738)

getV4RandomAddress and getV6RandomAddress mutated the per-pool and
per-subnet IP counters before calling GetStaticMac. When the MAC check
failed (static MAC conflict, gateway-MAC collision) they returned
without undoing those mutations, leaking the IP out of the pool. The
same gap existed in getDualRandomAddress when the v6 half failed after
the v4 half had already succeeded.

Split releaseAddr into single-family releaseV4Addr and releaseV6Addr
helpers so rollback paths can undo only the half they allocated. For
the dual-stack case, only roll back the IPv4 lease when this call
actually allocated it — fast-path cache hits must be left intact so
retries do not silently revoke a working pre-existing lease.

Add tests covering the random-address MAC conflict rollback, dual-stack
v6 failure rollback, and the symmetric cases where the nic already
holds a working v4/v6 lease that must survive the failure.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

96 of 102 new or added lines in 1 file covered. (94.12%)

14318 of 57189 relevant lines covered (25.04%)

0.29 hits per line