dangernoodle-io / breadboard / 25905757565

100%

push

github

feat(bb_release_manifest): extract GitHub parser from bb_ota_pull (B1-197) (#230)

Extract the platform-independent GitHub release manifest JSON parser
from bb_ota_pull into a new bb_release_manifest component with a
callback-based API (bb_release_manifest_parse_fn). Enables future
release parsers for other platforms (GitLab, Gitea, etc.) while
preserving backward compatibility: bb_ota_pull_parse_release_json
remains a thin wrapper converting bb_err_t codes to legacy int contract.

New component features:
- bb_release_manifest.h declares typedef and bb_release_manifest_parse_github
- bb_release_manifest_github.c implements JSON parser using minimal,
  escape-aware helpers (find_key, copy_string_value, match_brace)
- Accepts body_len parameter to support binary bodies in future parsers
- Returns bb_err_t (BB_OK / BB_ERR_NOT_FOUND / BB_ERR_INVALID_ARG)
- REQUIRES bb_core only (no HTTP/JSON/logging deps)

bb_ota_pull changes:
- Thin wrapper maps legacy 0/-1/-2 contract to bb_err_t
- Caller behavior unchanged; callers still call bb_ota_pull_parse_release_json
- Add bb_release_manifest to REQUIRES in CMakeLists.txt

Test coverage:
- 6 new tests in test_bb_release_manifest.c cover valid manifest,
  missing tag, missing asset, null args, bad JSON, multiple assets
- Existing bb_ota_pull tests pass unchanged (backward compatible)
- Total: 687 tests (684 pass; 2 pre-existing failures unrelated)

Build: smoke-esp32 and smoke-uno_cc3000 both green.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

706 of 706 branches covered (100.0%)

Branch coverage included in aggregate %.

84 of 84 new or added lines in 1 file covered. (100.0%)

1195 of 1195 relevant lines covered (100.0%)

1230.59 hits per line