supabase / etl / 25902608802

76%

Build Type

push

github

Committed by web-flow

Commit Message

Add clickhouse client- and server-side timeouts (#741)

* feat(error): add DestinationTimeout error kind

* feat(clickhouse): add ClickHouseClientConfig and thread through

Adds a sibling config struct to ClickHouseInserterConfig with per-operation
server-side timeout fields and a client_timeout_epsilon. Threaded through
ClickHouseDestination::new and ClickHouseClient::new; all existing callers
pass Default::default(). No behavior change yet: the new config field is
plumbed but not consulted.

* feat(clickhouse): wrap client calls in tokio::time::timeout

Adds TimeoutOp + timeout_call so each ClickHouseClient call is bound by
client_budget(server_budget) = server + epsilon. Server-side options
(connect_timeout, http_connection_timeout, http_send_timeout,
http_receive_timeout) are set globally; max_execution_time and
lock_acquire_timeout are applied per-call to DDL/TRUNCATE so they do not
leak into probe and schema_query budgets. Client-side deadlines surface as
DestinationTimeout.

* test(clickhouse): cover client_budget and timeout_call

Covers ClickHouseClientConfig::client_budget arithmetic, TimeoutOp::Display
matching the strings used in error messages, and timeout_call across its
three outcomes (deadline expired, inner error, success). Uses
tokio::test(start_paused = true) so the deadline test does not block on
real wall-clock time.

* ref(clickhouse): rename probe timeout, tighten config docs

Renames probe_server_timeout to connectivity_check_timeout and shortens
the doc-comments on ClickHouseClientConfig per review. Drops the epsilon
default from 5s to 4s.

* ref(clickhouse): rename TimeoutOp::Probe, drop timeout_kind()

Renames TimeoutOp::Probe to ConnectivityCheck (matching the
connectivity_check_timeout config field) and updates its Display string
to 'connectivity check'. Inlines ErrorKind::DestinationTimeout in
timeout_call and drops the now-trivial timeout_kind() helper.

* ref(clickhouse): let TimeoutOp drive the server budget

Adds Time... (continued)

Coverage Stats

237 of 240 new or added lines in 5 files covered. (98.75%)

20 existing lines in 5 files now uncovered.

30559 of 39575 relevant lines covered (77.22%)

944.78 hits per line