raystack / frontier / 25899610816

42%

main: 42%

Build Type

Pull #1615

github

Committed by whoAbhishekSah

Commit Message

fix(group): address CodeRabbit feedback on #1615

- core/group: use schema.GroupNamespace (semantic constant for the
  group-as-resource Object) instead of schema.GroupPrincipal in
  DeleteModel's wildcard relation delete. Both values are the same
  string today, but GroupNamespace is the correct constant for this
  call site.

- core/membership.RemoveAllGroupMembers: split into two passes.
  First pass attempts every policy delete and tracks principals with
  any failure. Second pass clears direct relations only for principals
  whose policies were all deleted. This avoids leaving a surviving
  policy without its matching SpiceDB tuples when a per-policy delete
  fails mid-loop — the previous code could strip relations after one
  policy succeeded for a principal even though a later policy delete
  for the same principal failed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #1615: refactor(group): move group-delete cleanup into membership package

Coverage Stats

50 of 72 new or added lines in 5 files covered. (69.44%)

16 existing lines in 1 file now uncovered.

16002 of 37700 relevant lines covered (42.45%)

11.89 hits per line