Alan-Jowett / sonde / 25883496585
81%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 124
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.027%. Remained the same
25883496585

push

github

web-flow 
fix(web-ui): show Diverged when unassigned program not yet cleared (#918)

* fix(web-ui): default ABI version to 2 on program ingestion

The program ingestion form defaulted \bi_version\ to 1, causing
operators to accidentally ingest programs with the wrong ABI version.
Change the HTML input default and JS fallback from 1 to 2, matching
the current ABI version.

Fixes #908

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix(web-ui): show Diverged when unassigned program not yet cleared

The dashboard convergence check used \desiredProgram && ...\ which
skipped the program comparison whenever \desired_assigned_program_hash\
was empty.  This meant unassigning a program from a node always showed
Aligned, even while the node still reported a current program hash.

Replace the truthy guard with \desired != null\ so divergence is
evaluated whenever a desired-state row exists.  When no desired-state
row exists (unmanaged node), program divergence is not flagged.

Also updates the design spec with explicit divergence-computation rules
and adds validation entries T-WEB-0105 (unassignment divergence) and
T-WEB-0106 (no desired row = aligned).

Fixes #909

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

34276 of 41283 relevant lines covered (83.03%)

194.4 hits per line

Jobs
ID Job ID Ran Files Coverage
1 25883496585.1 124
83.03
 GitHub Action Run
Source Files on build 25883496585