ingitdb / ingitdb-cli / 25883524573

96%

Build Type

push

github

Committed by inGitDB Dev

Commit Message

refactor(cli): polish describe helpers (advisory cleanup)

Addresses the four advisory items from the post-merge code-quality
review:

1. Extract loadLocalDef helper. The --path/--remote mutual-exclusion
   check, remote-not-yet-implemented error, resolveDBPath, and
   readDefinition were duplicated across bareNameDescribe,
   runDescribeCollection, and runDescribeView. Centralise in one
   function; each caller drops ~10 lines.

2. Split runDescribeCollection and runDescribeView into thin
   cobra-entry shims plus describeCollectionFromDef /
   describeViewFromMatches cores. bareNameDescribe now reuses the
   Definition and the view-match list it already resolved instead
   of re-walking the database — eliminates the double view-walk on
   bare-name invocations.

3. Make the second os.ReadDir in discoverCollectionChildren use the
   explicit error-check pattern, matching the sibling viewsDir block
   right above it.

4. Adopt strings.CutSuffix in discoverCollectionChildren and
   strings.Cut in the columnsSection test helper, per the gopls
   simplification suggestions.

Behavior is unchanged. All 23 packages still pass; 5/5 stress runs
of cmd/ingitdb/commands clean (no stdout-swap flake regression).
golangci-lint 0 issues.

specscore: feature/cli/describe

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

26 of 40 new or added lines in 1 file covered. (65.0%)

2 existing lines in 1 file now uncovered.

10672 of 11708 relevant lines covered (91.15%)

1.07 hits per line