AfterShip / clickhouse-sql-parser / 25881758201

52%

master: 52%

Build Type

Pull #270

github

Committed by sharadgaur

Commit Message

fix: support column list before ENGINE and fix DEPENDS ON multi-table in CREATE MATERIALIZED VIEW

1. Column list before ENGINE (new):
   ClickHouse SHOW CREATE TABLE for refreshable materialized views with
   ENGINE (e.g. Memory) outputs the column list between REFRESH and ENGINE:

     CREATE MATERIALIZED VIEW db1.mv_name
     REFRESH EVERY 1 SECOND
     (col1 String, col2 Int8)
     ENGINE = Memory
     AS SELECT ...

   The parser previously expected TO or ENGINE immediately after REFRESH
   clauses. Added support for (columns) before ENGINE by parsing a
   TableSchemaClause when a left paren is encountered.

2. DEPENDS ON multi-table (bug fix):
   The comma in 'DEPENDS ON db1.mv_a, db1.mv_b' was not consumed before
   parsing the next table identifier. Added missing consumeToken() call
   in the comma loop, matching the pattern used in parser_query.go.

Changes:
- parser/parser_view.go: handle (columns) before ENGINE; consume comma in DEPENDS ON loop
- parser/ast.go: add TableSchema field to CreateMaterializedView
- parser/format.go: emit TableSchema before ENGINE in FormatSQL
- parser/walk.go: traverse TableSchema in Walk

Tests:
- create_materialized_view_rmv_engine_with_columns.sql (column list + ENGINE)
- create_materialized_view_rmv_depends_on_multi.sql (multi-table DEPENDS ON)
- All 21 MV syntax variants tested, all existing tests pass

Pull Request Pull Request #270: fix: support column list before ENGINE in CREATE MATERIALIZED VIEW

Coverage Stats

16 of 24 new or added lines in 3 files covered. (66.67%)

1132 existing lines in 1 file now uncovered.

8268 of 16000 relevant lines covered (51.68%)

3015.86 hits per line