ingitdb / ingitdb-cli / 25867147742

96%

push

github

feat(dalgo2ingitdb): preserve real PK column names in definition.yaml

CreateCollection now persists dbschema.CollectionDef.PrimaryKey as
`primary_key:` in definition.yaml, and DescribeCollection round-trips it
back as []dal.FieldName. Composite PKs work for free — the YAML list
preserves order.

Previously DescribeCollection always synthesized PrimaryKey: ["$key"]
because inGitDB uses the record filename as the de-facto PK. That was
fine in isolation but it broke cross-engine round-trips: e.g.
SQLite → inGitDB → SQLite would lose the source PK column names, and
CREATE TABLE on the reverse hop produced `PRIMARY KEY ($key)` which
SQLite rejected ("parameters prohibited in index expressions").

Now newly-created inGitDB projects round-trip the source PK losslessly.
Legacy projects (definition.yaml without a primary_key field) keep the
backward-compatible ["$key"] synthesis — see AC:describe-collection-legacy-no-pk-field.

Spec changes (dalgo2ingitdb-dbschema-ddl-coverage):
- REQ:create-collection step 5: persist primary_key when source carries
  a non-empty PrimaryKey.
- REQ:describe-collection: PrimaryKey comes from definition.yaml when
  present, else synthesized.
- 3 new ACs: roundtrip-single, roundtrip-composite, legacy-no-pk-field.

ListConstraints: doc clarified — dbschema.ConstraintDef is Name + Type
only; the richer PK column info lives on DescribeCollection.PrimaryKey.

Tests added (all pass):
- TestCreateDescribe_PKRoundTrip_Single
- TestCreateDescribe_PKRoundTrip_Composite
- TestDescribe_LegacyNoPKField

specscore spec lint: 0 violations. golangci-lint run: 0 issues.
Full repo: 23 packages green.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

18 of 18 new or added lines in 2 files covered. (100.0%)

10348 of 11306 relevant lines covered (91.53%)

1.08 hits per line