stacklok / toolhive-studio / 25863854131

70%

main: 71%

Build Type

Pull #2253

github

Committed by samuv

Commit Message

fix(playground): preserve per-thread isolation and dual-write contract

Address review:

- writeThread now snapshots current globals into the per-thread columns
  when materialising a brand-new row. Previously the row was created
  with NULL provider/model/MCP/skills, which broke per-thread isolation
  for draft threads and any path that creates a thread without
  explicitly carrying the settings (e.g. reconcile-from-store).

- Dual-write call sites (model mutation, MCP server selector, MCP tools
  modal, skill selector) now short-circuit the global "last used" write
  when the per-thread write returns { success: false }. Otherwise the
  seed for new threads could mutate even though the active thread's
  selection did not persist.

- The selected-model mutation's onSuccess only seeds caches when the
  write actually succeeded, so the UI no longer flashes a selection
  that will disappear on refetch.

- Add migration 007 test coverage (columns added, snapshot from
  globals, NULL handling when globals are missing or empty, no-threads
  case) in schema-and-migrator.test.ts.

- Add thread-settings-storage.test.ts (22 cases) covering get/set
  selected model, MCP-tools merge-write, skill toggle add/remove/dedup
  /sort, draft-thread materialisation, and failure-result propagation.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #2253: feat(playground): per-thread model, MCP, and skills selection

Coverage Stats

5125 of 7926 branches covered (64.66%)

118 of 215 new or added lines in 18 files covered. (54.88%)

6 existing lines in 3 files now uncovered.

7616 of 10847 relevant lines covered (70.21%)

115.59 hits per line