schireson / pytest-mock-resources / 25863790105

89%

push

github

feat: strip DISTKEY/SORTKEY/DISTSTYLE clauses in raw SQL for Redshift fixture (#233)

* feat: strip DISTKEY/SORTKEY/DISTSTYLE clauses in raw SQL for Redshift fixture

These Redshift-only CREATE TABLE clauses are accepted by Redshift but
rejected by Postgres, causing the fixture to error on raw production SQL
that includes them. Strip them at execution time, mirroring how COPY and
UNLOAD are already handled, both on the SQLAlchemy and the direct
psycopg2 cursor paths.

Refs: #99

* fix: anchor Redshift DDL strip regexes with word boundaries

Without word boundaries, the SORTKEY regex matched the substring
"sortkey" inside identifiers like "example_distkey_sortkey", and the
greedy `[^)]*` then consumed the column-list parentheses up to the first
closing paren, mangling otherwise valid CREATE TABLE statements.

Anchor each Redshift keyword (DISTKEY, DISTSTYLE, SORTKEY, COMPOUND,
INTERLEAVED, AUTO/EVEN/KEY/ALL) with \\b so the regex only matches the
keyword as a standalone token, not as a fragment of a longer identifier.
Add a regression test that exercises a table name containing both
"distkey" and "sortkey" as substrings.

Refs: #99

349 of 429 branches covered (81.35%)

Branch coverage included in aggregate %.

17 of 17 new or added lines in 3 files covered. (100.0%)

1482 of 1628 relevant lines covered (91.03%)

16.57 hits per line