ingitdb / ingitdb-cli / 25859831724

96%

Build Type

push

github

Committed by inGitDB Dev

Commit Message

feat(dalgo2ingitdb): map Decimal→Float and Bytes→String (lossy carriers)

dbschemaTypeToIngitdb previously errored on dbschema.Decimal and
dbschema.Bytes. That blocked cross-engine schema replication for sources
whose columns produce those types — e.g. SQLite NUMERIC(p,s) (after the
recent dalgo2sqlite DATETIME/NUMERIC recognition fix) is reported as
dbschema.Decimal, and replicating the Chinook fixture's Invoice / Track
tables into inGitDB failed at CreateCollection with
`unsupported dbschema.Type: decimal`.

The mappings are intentionally lossy and documented on the function:

- Decimal → ColumnTypeFloat. YAML doubles round-trip cleanly for typical
  money/measurement precisions; very high precision/scale loses bits.
- Bytes → ColumnTypeString. The string column is the carrier; callers
  base64-encode the binary value into it.

Both are pragmatic: inGitDB has no native fixed-precision decimal or raw
bytes column. The alternative — failing schema replication — is worse
than the precision-loss footnote.

Existing unit tests asserted both types should error; updated those cases
to assert the new lossy mapping with a comment pointing at the rationale.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

6 of 6 new or added lines in 1 file covered. (100.0%)

105 existing lines in 4 files now uncovered.

8611 of 11289 relevant lines covered (76.28%)

0.89 hits per line