raystack / frontier / 25856711954

42%

main: 42%

Build Type

Pull #1615

github

Committed by whoAbhishekSah

Commit Message

refactor(group): move group-delete cleanup into membership package

Mirrors the project deletion pattern (handler → deleter → DeleteModel +
membership cleanup):

- core/membership.RemoveAllGroupMembers: deletes every policy on the
  group and every per-principal owner/member relation. No min-owner
  check; the group itself is being destroyed.
- core/group.Service.DeleteModel: minimal entity teardown — Object-side
  relations on the group + repo delete + audit. Replaces the previous
  combined Delete method that mixed membership cleanup into the entity
  service.
- core/deleter.DeleteGroup: orchestrator that calls
  RemoveAllGroupMembers then DeleteModel. Wired into the
  DeleteOrganization cascade and exposed via the CascadeDeleter
  interface.
- DeleteGroup handler routes through deleterService instead of
  groupService directly.

group.RemoveUsers / removeUsers stay — they serve the single-user
remove path in deleter.DeleteUser (cascade where the user is being
destroyed system-wide).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #1615: refactor(group): move group-delete cleanup into membership package

Coverage Stats

27 of 38 new or added lines in 5 files covered. (71.05%)

34 existing lines in 2 files now uncovered.

15979 of 37667 relevant lines covered (42.42%)

11.9 hits per line